That study didn't compare suicide rates with and without surgery, it compared post-op trans people with the general population (i.e. mostly cisgender people). It explicitly says "This study design sheds new light on transsexual persons' health after sex reassignment. It does not, however, address whether sex reassignment is an effective treatment or not."