Hacker Newsnew | past | comments | ask | show | jobs | submit | pawelmor's commentslogin

Thank you for your answer. This is more or less what I am trying to do. I agree that people caring about specs is a culture thing, I want to convince the VP that we need a clear workflow to work on complex features. If you had to recommend a tool, which one would it be ?


Some people only review the final diff and don't go through the code commit by commit.


There should be only a single commit, vetted by the code review.

What happens before on a private branch (usually on a local copy of the repo) can be purged (and probably should be purged as a matter of course) if there is a worry of what might be contained in there.

The bottom line for is that the most important is to define a good process first before trying to use tooling to correct process deficiencies. A good process brings many benefits by 'forcing' good outcomes and avoid a lot of headaches.


I completely agree that this is how the review should be done.

But this is not the case in all companies.


> But this is not the case in all companies.

In that case it's worth fixing the process before adding layers of tooling.


Not the current state of the world!


The same works:

  <details>
  <summary>Title</summary>
  ...
  </details>



GitGuardan | www.gitguardian.com | Paris, Onsite

We are GitGuardian. Every second on average we scan 100 commits on GitHub making sure you are notified when you leak a secret.

Learn more about how it works here : https://github.com/GitGuardian/Getting-Started-With-The-Indi...

If you like to work with IT security, Python, React or Go shoot me an email: pawel <at> gitguardian com

If you want more information about the company feel free to check us out at https://www.welcometothejungle.co/en/companies/gitguardian


Junior R&D / Software Engineer

Location: Paris, France

Remote: Yes

Willing to relocate: Yes

Technologies: Python, React, Django REST

Resume : Available on request

Email : p.mor awian <at> <gmail> .com

Linkedin : https://www.linkedin.com/in/pawel-mo/


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: